Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Internal] Tests: Fixes tests configuration #1767

Merged
merged 2 commits into from
Aug 10, 2020
Merged

Conversation

ealsur
Copy link
Member

@ealsur ealsur commented Aug 10, 2020

Unit tests project runs on Release configuration, which makes any Debug.Assert calls moot for verification purposes.

@ealsur ealsur merged commit 3166eb6 into master Aug 10, 2020
@ealsur ealsur deleted the users/ealsur/unittestsdebug branch August 10, 2020 21:49
kirankumarkolli added a commit that referenced this pull request Aug 11, 2020
* Performance: Adds includes compiler optimize option

* Update Microsoft.Azure.Cosmos/src/Microsoft.Azure.Cosmos.csproj

Co-authored-by: Matias Quaranta <ealsur@users.noreply.github.com>

* Update Microsoft.Azure.Cosmos.Samples/Tools/Benchmark/CosmosBenchmark.csproj

Co-authored-by: Matias Quaranta <ealsur@users.noreply.github.com>

* [Internal] Tests: Fixes bad debug assert causing test failures (#1766)

* [Internal] Tests: Fixes tests configuration (#1767)

Co-authored-by: j82w <j82w@users.noreply.github.com>

* Performance: Adds includes compiler optimize option

* Update Microsoft.Azure.Cosmos/src/Microsoft.Azure.Cosmos.csproj

Co-authored-by: Matias Quaranta <ealsur@users.noreply.github.com>

* Update Microsoft.Azure.Cosmos.Samples/Tools/Benchmark/CosmosBenchmark.csproj

Co-authored-by: Matias Quaranta <ealsur@users.noreply.github.com>

Co-authored-by: Matias Quaranta <ealsur@users.noreply.github.com>
Co-authored-by: j82w <j82w@users.noreply.github.com>
@ghost
Copy link

ghost commented Dec 15, 2021

Closing due to in-activity, pease feel free to re-open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants